From 07dbf228f09936a550e1d5a9513133601ca980d4 Mon Sep 17 00:00:00 2001 From: Vaci Koblizek Date: Fri, 2 Oct 2020 22:53:49 +0100 Subject: [PATCH] avoid repetition of getResultsBuilder call --- .../src/main/java/org/capnproto/RpcState.java | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/runtime/src/main/java/org/capnproto/RpcState.java b/runtime/src/main/java/org/capnproto/RpcState.java index 453be6e..da61be9 100644 --- a/runtime/src/main/java/org/capnproto/RpcState.java +++ b/runtime/src/main/java/org/capnproto/RpcState.java @@ -991,17 +991,16 @@ final class RpcState { @Override public AnyPointer.Builder getResults() { - if (response != null) { - return response.getResultsBuilder(); - } + if (response == null) { - if (redirectResults || isDisconnected()) { - response = new LocallyRedirectedRpcResponse(); - } - else { - var message = connection.newOutgoingMessage(1024); - returnMessage = message.getBody().initAs(RpcProtocol.Message.factory).initReturn(); - response = new RpcServerResponseImpl(message, returnMessage.getResults()); + if (redirectResults || isDisconnected()) { + response = new LocallyRedirectedRpcResponse(); + } + else { + var message = connection.newOutgoingMessage(1024); + returnMessage = message.getBody().initAs(RpcProtocol.Message.factory).initReturn(); + response = new RpcServerResponseImpl(message, returnMessage.getResults()); + } } return response.getResultsBuilder();