From d5e0a8c02d68c346bbebc3560897e5ec8aefda45 Mon Sep 17 00:00:00 2001 From: Adam Rosenberger Date: Mon, 19 May 2014 08:43:58 -0400 Subject: [PATCH] Cosmetic refactor: add final keyword where possible --- .../main/java/org/capnproto/AnyPointer.java | 6 +++--- .../java/org/capnproto/DecodeException.java | 2 +- .../main/java/org/capnproto/FieldSize.java | 2 +- .../java/org/capnproto/FromStructBuilder.java | 4 ++-- .../java/org/capnproto/FromStructReader.java | 2 +- .../capnproto/InputStreamMessageReader.java | 7 +++---- .../main/java/org/capnproto/ListBuilder.java | 12 +++++------ .../main/java/org/capnproto/ListReader.java | 21 +++++++++---------- .../java/org/capnproto/MessageReader.java | 4 ++-- .../java/org/capnproto/PointerBuilder.java | 4 ++-- .../java/org/capnproto/PointerReader.java | 8 +++---- .../java/org/capnproto/SegmentBuilder.java | 6 +++--- .../java/org/capnproto/SegmentReader.java | 2 +- .../java/org/capnproto/StructBuilder.java | 16 +++++++------- .../main/java/org/capnproto/StructList.java | 1 - .../main/java/org/capnproto/StructReader.java | 19 ++++++++--------- runtime/src/main/java/org/capnproto/Text.java | 4 ++-- 17 files changed, 58 insertions(+), 62 deletions(-) diff --git a/runtime/src/main/java/org/capnproto/AnyPointer.java b/runtime/src/main/java/org/capnproto/AnyPointer.java index 26346e8..a101cde 100644 --- a/runtime/src/main/java/org/capnproto/AnyPointer.java +++ b/runtime/src/main/java/org/capnproto/AnyPointer.java @@ -1,9 +1,9 @@ package org.capnproto; -public class AnyPointer { +public final class AnyPointer { - public static class Reader { - public PointerReader reader; + public final static class Reader { + public final PointerReader reader; public Reader(PointerReader reader) { this.reader = reader; diff --git a/runtime/src/main/java/org/capnproto/DecodeException.java b/runtime/src/main/java/org/capnproto/DecodeException.java index 4aad297..f8026d8 100644 --- a/runtime/src/main/java/org/capnproto/DecodeException.java +++ b/runtime/src/main/java/org/capnproto/DecodeException.java @@ -1,6 +1,6 @@ package org.capnproto; -public class DecodeException extends RuntimeException { +public final class DecodeException extends RuntimeException { public DecodeException(String message) { super(message); } diff --git a/runtime/src/main/java/org/capnproto/FieldSize.java b/runtime/src/main/java/org/capnproto/FieldSize.java index 52886ad..c3043b7 100644 --- a/runtime/src/main/java/org/capnproto/FieldSize.java +++ b/runtime/src/main/java/org/capnproto/FieldSize.java @@ -1,6 +1,6 @@ package org.capnproto; -public class FieldSize { +public final class FieldSize { public static final byte VOID = 0; public static final byte BIT = 1; public static final byte BYTE = 2; diff --git a/runtime/src/main/java/org/capnproto/FromStructBuilder.java b/runtime/src/main/java/org/capnproto/FromStructBuilder.java index 4b44e0b..5477a74 100644 --- a/runtime/src/main/java/org/capnproto/FromStructBuilder.java +++ b/runtime/src/main/java/org/capnproto/FromStructBuilder.java @@ -1,6 +1,6 @@ package org.capnproto; public interface FromStructBuilder { - public abstract T fromStructBuilder(StructBuilder builder); - public abstract StructSize structSize(); + T fromStructBuilder(StructBuilder builder); + StructSize structSize(); } diff --git a/runtime/src/main/java/org/capnproto/FromStructReader.java b/runtime/src/main/java/org/capnproto/FromStructReader.java index eaf1413..660784f 100644 --- a/runtime/src/main/java/org/capnproto/FromStructReader.java +++ b/runtime/src/main/java/org/capnproto/FromStructReader.java @@ -1,5 +1,5 @@ package org.capnproto; public interface FromStructReader { - public abstract T fromStructReader(StructReader reader); + T fromStructReader(StructReader reader); } diff --git a/runtime/src/main/java/org/capnproto/InputStreamMessageReader.java b/runtime/src/main/java/org/capnproto/InputStreamMessageReader.java index 1d8f796..489b865 100644 --- a/runtime/src/main/java/org/capnproto/InputStreamMessageReader.java +++ b/runtime/src/main/java/org/capnproto/InputStreamMessageReader.java @@ -1,13 +1,12 @@ package org.capnproto; -import java.io.InputStream; import java.io.IOException; +import java.io.InputStream; import java.nio.ByteBuffer; import java.nio.ByteOrder; import java.util.Vector; - -public class InputStreamMessageReader { +public final class InputStreamMessageReader { static byte[] readExact(InputStream is, int length) throws IOException { byte[] bytes = new byte[length]; @@ -52,7 +51,7 @@ public class InputStreamMessageReader { if (segmentCount > 1) { ByteBuffer moreSizesRaw = makeByteBuffer(readExact(is, 4 * (segmentCount & ~1))); - for(int ii = 0; ii < segmentCount - 1; ++ii) { + for (int ii = 0; ii < segmentCount - 1; ++ii) { int size = moreSizesRaw.getInt(ii * 4); moreSizes.add(size); totalWords += size; diff --git a/runtime/src/main/java/org/capnproto/ListBuilder.java b/runtime/src/main/java/org/capnproto/ListBuilder.java index cb5edbe..4891fca 100644 --- a/runtime/src/main/java/org/capnproto/ListBuilder.java +++ b/runtime/src/main/java/org/capnproto/ListBuilder.java @@ -1,12 +1,12 @@ package org.capnproto; public final class ListBuilder { - SegmentBuilder segment; - int ptr; // byte offset to front of list - int elementCount; - int step; // in bits - int structDataSize; // in bits - short structPointerCount; + final SegmentBuilder segment; + final int ptr; // byte offset to front of list + final int elementCount; + final int step; // in bits + final int structDataSize; // in bits + final short structPointerCount; public ListBuilder(SegmentBuilder segment, int ptr, int elementCount, int step, diff --git a/runtime/src/main/java/org/capnproto/ListReader.java b/runtime/src/main/java/org/capnproto/ListReader.java index 4c019f9..a63ad60 100644 --- a/runtime/src/main/java/org/capnproto/ListReader.java +++ b/runtime/src/main/java/org/capnproto/ListReader.java @@ -1,16 +1,15 @@ package org.capnproto; -public class ListReader { - SegmentReader segment; - int ptr; // byte offset to front of list - int elementCount; - int step; // in bits - int structDataSize; // in bits - short structPointerCount; - int nestingLimit; +public final class ListReader { + final SegmentReader segment; + final int ptr; // byte offset to front of list + final int elementCount; + final int step; // in bits + final int structDataSize; // in bits + final short structPointerCount; + final int nestingLimit; - - public ListReader () { + public ListReader() { this.segment = null; this.ptr = 0; this.elementCount = 0; @@ -47,6 +46,6 @@ public class ListReader { int structPointers = structData + (this.structDataSize / 8); return new StructReader(this.segment, structData, structPointers / 8, this.structDataSize, - this.structPointerCount, (byte)(indexBit % 8), this.nestingLimit - 1); + this.structPointerCount, (byte) (indexBit % 8), this.nestingLimit - 1); } } diff --git a/runtime/src/main/java/org/capnproto/MessageReader.java b/runtime/src/main/java/org/capnproto/MessageReader.java index 2248638..9f0d2b5 100644 --- a/runtime/src/main/java/org/capnproto/MessageReader.java +++ b/runtime/src/main/java/org/capnproto/MessageReader.java @@ -2,8 +2,8 @@ package org.capnproto; import java.nio.ByteBuffer; -public class MessageReader { - ByteBuffer[] segmentSlices; +public final class MessageReader { + final ByteBuffer[] segmentSlices; public MessageReader(ByteBuffer[] segmentSlices) { this.segmentSlices = segmentSlices; diff --git a/runtime/src/main/java/org/capnproto/PointerBuilder.java b/runtime/src/main/java/org/capnproto/PointerBuilder.java index f470d20..5f583c2 100644 --- a/runtime/src/main/java/org/capnproto/PointerBuilder.java +++ b/runtime/src/main/java/org/capnproto/PointerBuilder.java @@ -1,8 +1,8 @@ package org.capnproto; public final class PointerBuilder { - public SegmentBuilder segment; - public int pointer; // word offset + public final SegmentBuilder segment; + public final int pointer; // word offset public PointerBuilder(SegmentBuilder segment, int pointer) { this.segment = segment; diff --git a/runtime/src/main/java/org/capnproto/PointerReader.java b/runtime/src/main/java/org/capnproto/PointerReader.java index dd75ce0..7c37588 100644 --- a/runtime/src/main/java/org/capnproto/PointerReader.java +++ b/runtime/src/main/java/org/capnproto/PointerReader.java @@ -1,9 +1,9 @@ package org.capnproto; -public class PointerReader { - public SegmentReader segment; - public int pointer; // word offset - public int nestingLimit; +public final class PointerReader { + public final SegmentReader segment; + public final int pointer; // word offset + public final int nestingLimit; public PointerReader() { this.segment = null; diff --git a/runtime/src/main/java/org/capnproto/SegmentBuilder.java b/runtime/src/main/java/org/capnproto/SegmentBuilder.java index 08e1160..5641099 100644 --- a/runtime/src/main/java/org/capnproto/SegmentBuilder.java +++ b/runtime/src/main/java/org/capnproto/SegmentBuilder.java @@ -2,11 +2,11 @@ package org.capnproto; import java.nio.ByteBuffer; -public class SegmentBuilder extends SegmentReader { - public int pos = 0; // in words - +public final class SegmentBuilder extends SegmentReader { public static final int FAILED_ALLOCATION = -1; + public int pos = 0; // in words + public SegmentBuilder(ByteBuffer buf) { super(buf); } diff --git a/runtime/src/main/java/org/capnproto/SegmentReader.java b/runtime/src/main/java/org/capnproto/SegmentReader.java index bc53125..c55aafb 100644 --- a/runtime/src/main/java/org/capnproto/SegmentReader.java +++ b/runtime/src/main/java/org/capnproto/SegmentReader.java @@ -3,7 +3,7 @@ package org.capnproto; import java.nio.ByteBuffer; public class SegmentReader { - ByteBuffer buffer; + final ByteBuffer buffer; public SegmentReader(ByteBuffer buffer) { this.buffer = buffer; diff --git a/runtime/src/main/java/org/capnproto/StructBuilder.java b/runtime/src/main/java/org/capnproto/StructBuilder.java index 3ff05c0..c8d6cc9 100644 --- a/runtime/src/main/java/org/capnproto/StructBuilder.java +++ b/runtime/src/main/java/org/capnproto/StructBuilder.java @@ -1,16 +1,16 @@ package org.capnproto; public final class StructBuilder { - public SegmentBuilder segment; - public int data; //byte offset to data section - public int pointers; // word offset of pointer section - public int dataSize; // in bits - public short pointerCount; - public byte bit0Offset; + public final SegmentBuilder segment; + public final int data; //byte offset to data section + public final int pointers; // word offset of pointer section + public final int dataSize; // in bits + public final short pointerCount; + public final byte bit0Offset; public StructBuilder(SegmentBuilder segment, int data, - int pointers, int dataSize, short pointerCount, - byte bit0Offset) { + int pointers, int dataSize, short pointerCount, + byte bit0Offset) { this.segment = segment; this.data = data; this.pointers = pointers; diff --git a/runtime/src/main/java/org/capnproto/StructList.java b/runtime/src/main/java/org/capnproto/StructList.java index 4027907..6750a07 100644 --- a/runtime/src/main/java/org/capnproto/StructList.java +++ b/runtime/src/main/java/org/capnproto/StructList.java @@ -1,6 +1,5 @@ package org.capnproto; - public final class StructList { public static final class Reader { public ListReader reader; diff --git a/runtime/src/main/java/org/capnproto/StructReader.java b/runtime/src/main/java/org/capnproto/StructReader.java index 23c45f9..a193452 100644 --- a/runtime/src/main/java/org/capnproto/StructReader.java +++ b/runtime/src/main/java/org/capnproto/StructReader.java @@ -1,14 +1,13 @@ package org.capnproto; public final class StructReader { - public SegmentReader segment; - public int data; //byte offset to data section - public int pointers; // word offset of pointer section - public int dataSize; // in bits - public short pointerCount; - public byte bit0Offset; - public int nestingLimit; - + public final SegmentReader segment; + public final int data; //byte offset to data section + public final int pointers; // word offset of pointer section + public final int dataSize; // in bits + public final short pointerCount; + public final byte bit0Offset; + public final int nestingLimit; public StructReader(SegmentReader segment, int data, int pointers, int dataSize, short pointerCount, @@ -62,8 +61,8 @@ public final class StructReader { public final PointerReader getPointerField(int ptrIndex) { if (ptrIndex < this.pointerCount) { return new PointerReader(this.segment, - this.pointers + ptrIndex, - this.nestingLimit); + this.pointers + ptrIndex, + this.nestingLimit); } else { return new PointerReader(); } diff --git a/runtime/src/main/java/org/capnproto/Text.java b/runtime/src/main/java/org/capnproto/Text.java index d347fed..9ed8dc1 100644 --- a/runtime/src/main/java/org/capnproto/Text.java +++ b/runtime/src/main/java/org/capnproto/Text.java @@ -2,7 +2,7 @@ package org.capnproto; import java.nio.ByteBuffer; -public class Text { +public final class Text { public static final class Reader { public final ByteBuffer buffer; @@ -35,7 +35,7 @@ public class Text { try { return new String(bytes, "UTF-8"); - } catch(java.io.UnsupportedEncodingException e) { + } catch (java.io.UnsupportedEncodingException e) { return "unsupported encoding"; // XXX } }